feat: introduce AnnotationDependentResourceConfigurator concept #1532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Chris Laprun <[email protected]>
* feat: decouple event source from cache + list discriminator (#1378) * feat: bulk dependent resources (#1448) * feat: optional eventsource on dependent resources (#1479) * refactor: simplify handling of reused event sources (#1518) Co-authored-by: Chris Laprun <[email protected]> * refactor: isolate index handling to BulkDependentResource interface (#1517) * feat: key based bulk resource creation (#1521) * improvement: bulk dependent resource api * merge Co-authored-by: Chris Laprun <[email protected]> Co-authored-by: Chris Laprun <[email protected]>
metacosm
force-pushed
the
unify-configuration-2
branch
from
6095777 to
ef266b3
Compare
csviri
requested changes
Oct 17, 2022
.../src/main/java/io/javaoperatorsdk/operator/api/config/AnnotationControllerConfiguration.java
Show resolved
Hide resolved
...e/src/main/java/io/javaoperatorsdk/operator/api/config/ControllerConfigurationOverrider.java
Outdated
Show resolved
Hide resolved
...javaoperatorsdk/operator/api/reconciler/dependent/managed/DependentResourceConfigurator.java
Show resolved
Hide resolved
...hema/src/main/java/io/javaoperatorsdk/operator/sample/dependent/SchemaDependentResource.java
Outdated
Show resolved
Hide resolved
...hema/src/main/java/io/javaoperatorsdk/operator/sample/dependent/SchemaDependentResource.java
Show resolved
Hide resolved
...javaoperatorsdk/operator/api/reconciler/dependent/managed/DependentResourceConfigurator.java
Show resolved
Hide resolved
Otherwise looks very good :) |
* refactor: deleteBulkResource -> deleteTargetResource * refactor: remove now unneeded class * refactor: deleteBulkResourcesIfRequired -> deleteExtraResources * fix: javadoc
The idea is to be able to configure dependents using annotations directly so that we can remove the special handling of KubernetesDependentResource from AnnotationControllerConfiguration. This results in dependent resources being instantiated and configured directly when processed from the annotations in the managed case, thus rendering the DependentResourceFactory concept obsolete. This should also lead to further simplification later.
metacosm
force-pushed
the
unify-configuration-2
branch
from
ef266b3 to
efcfe39
Compare
|
Kudos, SonarCloud Quality Gate passed! |
csviri
reviewed
Oct 19, 2022
...e/src/main/java/io/javaoperatorsdk/operator/api/config/ControllerConfigurationOverrider.java
Show resolved
Hide resolved
csviri
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to be able to configure dependents using annotations
directly so that we can remove the special handling of
KubernetesDependentResource from AnnotationControllerConfiguration. This
results in dependent resources being instantiated and configured
directly when processed from the annotations in the managed case, thus
rendering the DependentResourceFactory concept obsolete. This should
also lead to further simplification later.